Date: Fri, 16 Jan 2004 19:09:03 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Jun-ichiro itojun Hagino <itojun@itojun.org> Subject: Re: [PATCH] IPSec fixes Message-ID: <yged69kurwg.wl%ume@FreeBSD.org> In-Reply-To: <Pine.BSF.4.53.0401160829530.66397@e0-0.zab2.int.zabbadoz.net> References: <Pine.BSF.4.53.0401140934230.30149@e0-0.zab2.int.zabbadoz.net> <20040115041435.7B739A6@coconut.itojun.org> <Pine.BSF.4.53.0401152212230.66397@e0-0.zab2.int.zabbadoz.net> <ygeeku0uxas.wl%ume@FreeBSD.org> <Pine.BSF.4.53.0401160829530.66397@e0-0.zab2.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, >>>>> On Fri, 16 Jan 2004 09:31:25 +0000 (UTC) >>>>> bzeeb-lists@lists.zabbadoz.net ("Bjoern A. Zeeb") said: bzeeb-lists> I never applied it as going through the code showed that it will not bzeeb-lists> do the right thing(TM). See older mail. You wrote that the check is entirely useless. However, the patch actually changed the behavior and fixed the problem on my box. Without the patch, I could reproduce a panic easily by setkey. So, I wish to hear an actuall result on your box. bzeeb-lists> ahh - this isn't exactly the diff itojun offered. bzeeb-lists> the newsp->refcnt++; is missing. Is it also missing in your kernel ? Yes. Since you pointed that this is wrong, and itojun agreed with it. So, I nuked this line. bzeeb-lists> PS: do you have other patches in your local tree that are not yet bzeeb-lists> in HEAD ? I got another patch from you once in Nov or Dec but I think bzeeb-lists> it was renaming functions and passing pcb instead of so only (removing bzeeb-lists> some unnecessary function calls) [more like FATS_IPSEC]. I have a more bzeeb-lists> improved version of this in my private patchset but currently bzeeb-lists> suspended while debugging. No, I'm not applying any other patches. Originally, it was jlemon's work. It was withdrawed during KAME merge. When this issue is fixed, I'll rework about this. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yged69kurwg.wl%ume>